Refactored ZUNIONSTORE, ZINTERSTORE, removed Numkeys trait, improved Withscores response parsing #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladvildanov
force-pushed
the
vv-zinterstore-zunionstore-refactoring
branch
from
6062649 to
e2272b3
Compare
added 2 commits
December 8, 2022 12:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored following commands to make them easy to extend (ZUNIONSTORE, ZUNION, ZINTERSTORE, ZINTER is the same family of commands, ZUNIONSTORE implemented first and should be a base for other commands from family).
Removed Numkeys trait and moved functionality into Keys, because they're never exists in separate, whenever we pass keys arguments as array we anyway need to calculate numkeys count
Added check for empty array within Withscores trait, to prevent from exception if empty response was returned