Prevent early failure when a slave is loading dataset.#475
Closed
esler wants to merge 3 commits into
Closed
Conversation
when one slave gets back online but is still loading the dataset from disk (when this happens, Redis returns the -LOADING error response).
|
any chance of this getting merged in? we are experiencing this issue with using sentinel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same problem like #280
I'm getting this exception
I'm using
Predis\Connection\Aggregate\SentinelReplicationwhich is missing previous fix. I've prepared simple fix in the fashion of previous fix. I'm not sure about not removing failing slave from the pool but it works for my problem.