Added temporary XREADGROUP_CLAIM command #1608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htemelski-oss
approved these changes
Nov 10, 2025
Contributor
htemelski-oss
left a comment
htemelski-oss
left a comment
There was a problem hiding this comment.
Looks good.
One question only:
$keysCount = $keysAndIdsCount / 2;Should we add a validation that keysAndIdsCount is an even number?
tillkruss
reviewed
Nov 10, 2025
Contributor
Author
|
@htemelski-redis There's no way to have odd number of key => id pairs, array always has an index and value or key and value |
tillkruss
approved these changes
Nov 11, 2025
|
nice, @vladvildano!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1606