Retry all exceptions from Sentinel replicas #1577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Throwable interface
…Throwable interface
ridgey-dev
changed the title
Contributor
|
@ridgey-dev Oh, thanks for your contribution! LGTM |
vladvildanov
approved these changes
Jul 17, 2025
tillkruss
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
v2.x, failures from stream_socket_client() would result in aCommunicationException, which is caught and retried bySentinelReplication.In
v3.x, such failures now throw aStreamInitException, which is not a subclass ofCommunicationException, and thus bypasses the existing retry logic.Change
Replaces the catch (
CommunicationException $e) block with catch (Throwable $e)Maintains existing retry behavior, but broadens the scope to handle all exceptions thrown during connection attempts, including
StreamInitExceptionand any future unexpected errors.Justification
Brings retry handling in SentinelReplication in line with the logic already adopted in RedisCluster (#788)