implement XSETID command #1559
Merged
implement XSETID command #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
approved these changes
Jun 12, 2025
Contributor
|
@alschastny The RESP2 test doesn't work with Relay, as Relay is RESP3 only and it returns already parsed response (associative array), we have to check if XINFO STREAM response is already associative array and does not apply parsing in this case |
alschastny
force-pushed
the
xsetid-command
branch
from
658e01c to
1d2a349
Compare
Contributor
Author
|
I decided to split the test into 2 methods, one working with relay, and a more advanced one that is not compatible with relay. I also found another bug in XINFO, I will send a PR with a fix soon. |
vladvildanov
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last of the missing commands for redis streams (https://redis.io/docs/latest/commands/xsetid/). And although it is marked as internal in the documentation, sometimes I had to use it.