Fix return type for ZCOUNT #1546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please advice regarding the CHANGELOG entry. Is sending a PR targeting v2.x even appropriate? I'm seeing main has “Unreleased” in the CHANGELOG, but v2.x does not. |
Contributor
|
@TimWolla Hi! I think v2.x is CVE and bugfixes only, correct me if I'm wrong @tillkruss |
Contributor
Author
I would say that fixing the return type to match the reality is a bugfix 😄 |
ZCOUNT returns an `int`: > Integer reply: the number of members in the specified score range.
tillkruss
approved these changes
May 26, 2025
Member
tillkruss
left a comment
tillkruss
left a comment
There was a problem hiding this comment.
Looks like the tests are checking for integers as well.
vladvildanov
approved these changes
May 27, 2025
vladvildanov
pushed a commit
that referenced
this pull request
May 27, 2025
* Fix return type for ZCOUNT ZCOUNT returns an `int`: > Integer reply: the number of members in the specified score range. * Update CHANGELOG.md --------- Co-authored-by: Till Krüss <[email protected]>
tillkruss
added a commit
that referenced
this pull request
May 27, 2025
* Fix return type for ZCOUNT (#1546) * Fix return type for ZCOUNT ZCOUNT returns an `int`: > Integer reply: the number of members in the specified score range. * Update CHANGELOG.md --------- Co-authored-by: Till Krüss <[email protected]> * Added changelog entry --------- Co-authored-by: Tim Düsterhus <[email protected]> Co-authored-by: Till Krüss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZCOUNT returns an
int: