Skip to content

fix(auth): Adds default user if only password used for authentication #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tillkruss merged 24 commits into from
May 13, 2025
Merged

fix(auth): Adds default user if only password used for authentication #1535

tillkruss merged 24 commits into from
May 13, 2025

Conversation

@vladvildanov
Copy link
Contributor

@vladvildanov vladvildanov commented May 5, 2025 •
edited
Loading

Closes #1534

@vladvildanov vladvildanov requested a review from tillkruss as a code owner May 5, 2025 08:59
@vladvildanov vladvildanov changed the title fix(auth): Added default user if only password used for authentication fix(auth): Adds default user if only password used for authentication May 5, 2025
@coveralls
Copy link

coveralls commented May 5, 2025 •
edited
Loading

Coverage Status

coverage: 92.676% (+0.01%) from 92.662%
when pulling 8983f1d on vv-1534-fix
into 3cc3547 on main.

@tillkruss tillkruss added the bug label May 5, 2025
@tillkruss tillkruss added this to the v3.x milestone May 5, 2025
tillkruss
tillkruss reviewed May 5, 2025
View reviewed changes
tillkruss
tillkruss reviewed May 5, 2025
View reviewed changes
elena-kolevska
elena-kolevska reviewed May 5, 2025
View reviewed changes
@vladvildanov
Copy link
Contributor Author

vladvildanov commented May 12, 2025

@tillkruss Ready for review

elena-kolevska
elena-kolevska reviewed May 12, 2025
View reviewed changes
Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tillkruss
tillkruss reviewed May 12, 2025
View reviewed changes
@tillkruss tillkruss merged commit 06c904a into main May 13, 2025
104 of 109 checks passed
@tillkruss tillkruss deleted the vv-1534-fix branch May 13, 2025 16:01
@denydias denydias mentioned this pull request May 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tillkruss tillkruss tillkruss approved these changes

+1 more reviewer

@elena-kolevska elena-kolevska elena-kolevska left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vladvildanov vladvildanov

Labels

bug

Milestone

v3.x

Development

Successfully merging this pull request may close these issues.

WRONGPASS invalid username-password pair or user is disabled after upgrading to predis 3

5 participants

@vladvildanov @coveralls @tillkruss @elena-kolevska