Added testing with 8.0 #1510
Merged
Added testing with 8.0 #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
reviewed
Feb 13, 2025
tillkruss
requested changes
Feb 13, 2025
…v-testing-with-8.0
…v-testing-with-8.0
tillkruss
previously approved these changes
Feb 14, 2025
|
@tillkruss I agree, we can make it as a part of this PR. I'll take care of it |
|
@tillkruss What about keep 7.2, 8.3, 8.4? PHP provides official support for two latest versions, so it's still possible that something might be broken and fixed in 8.3 as well |
tillkruss
requested changes
Feb 18, 2025
|
@tillkruss Done |
|
Thanks! 4.0 so we test against some common old versions. |
tillkruss
approved these changes
Feb 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added testing against 8.0. Changed test infrastructure to use client specific docker images.
Client specific images is a separate docker images provided and maintained by Clients & Ecosystems team within Redis LTD. They're used specifically for unified creation of test infrastructure across different clients, and provides out of the box different types of environments including Standalone, Cluster, Sentinel, Stack. Full support for TLS connections