Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4.0 compatibility with call to stream_context_set_option #1503

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

nicchap
Copy link
Contributor

@nicchap nicchap commented Jan 19, 2025

PHP 8.4.0 deprecated calls to stream_context_set_option with 2 arguments. Use stream_context_set_options function instead. Although the function is only deprecated, this will remove the deprecation message.

@nicchap nicchap requested a review from tillkruss as a code owner January 19, 2025 21:02
@tillkruss tillkruss self-assigned this Jan 20, 2025
@tillkruss tillkruss added the bug label Jan 20, 2025
nicchap and others added 3 commits January 22, 2025 09:07
Added PHP 8.4 compatible call to stream_context_set_options keeping backwards compatibility with pre PHP 8.4 versions
cleanup formatting - remove spaces
@radimvaculik
Copy link

@tillkruss Any ETA for release? Thanks!

@tillkruss
Copy link
Member

@tillkruss Any ETA for release? Thanks!

@vladvildanov Anything else you want in v2.x before we tag?

@vladvildanov
Copy link
Contributor

vladvildanov commented Mar 13, 2025

@tillkruss Redis 8.0-RC1 is about to be released (this week) and it will bring new Hash-Field expiration commands. I would like to contribute and include it into 2.x. Maybe we can release a new version of client along with Redis 8.0 GA, this way we ensure that new release is fully compatible with 8.0?

@tillkruss
Copy link
Member

Sounds good! Let's tag after we merge that one. It's time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants