Skip to content

ClientInterface: update watch command accepting string and string[] #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tillkruss merged 2 commits into from
Feb 13, 2025
Merged

ClientInterface: update watch command accepting string and string[] #1476

tillkruss merged 2 commits into from
Feb 13, 2025

Conversation

@glaubinix
Copy link
Contributor

@glaubinix glaubinix commented Aug 29, 2024

@glaubinix glaubinix requested a review from tillkruss as a code owner August 29, 2024 17:20
@coveralls
Copy link

coveralls commented Aug 29, 2024 •
edited
Loading

Coverage Status

coverage: 80.539%. remained the same
when pulling 6320af3 on glaubinix:patch-3
into 8fbd34c on predis:v2.x.

tillkruss
tillkruss requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@tillkruss tillkruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests.

@glaubinix
Copy link
Contributor Author

glaubinix commented Oct 16, 2024

There already was WATCH_Test::testFilterArgumentsAsSingleArray which asserts that passing a list gets converted to the correct structure. Added a test that shows watching works both via $redis1->watch('foo', 'bar') and $redis1->watch(['foo', 'bar'])

@glaubinix glaubinix requested a review from tillkruss October 16, 2024 11:56
@tillkruss tillkruss self-assigned this Feb 13, 2025
@tillkruss tillkruss merged commit 355faa0 into predis:v2.x Feb 13, 2025
66 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tillkruss tillkruss tillkruss approved these changes

Assignees

@tillkruss tillkruss

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glaubinix @coveralls @tillkruss