Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep key and value when filtering SET arguments #1471

Merged
merged 1 commit into from
Jul 11, 2024
Merged

keep key and value when filtering SET arguments #1471

merged 1 commit into from
Jul 11, 2024

Conversation

xabbuh
Copy link
Contributor

@xabbuh xabbuh commented Jul 9, 2024 •
edited
Loading

With the changes done in #1470 the value that is going to be set is also filtered which prevents setting a key to false or null.

@xabbuh xabbuh requested a review from tillkruss as a code owner July 9, 2024 20:11
@xabbuh xabbuh requested a review from a team July 9, 2024 20:11
@coveralls
Copy link

Coverage Status

coverage: 80.415% (+0.01%) from 80.401%
when pulling fa3139b on xabbuh:pr-1470
into 274e0c1 on predis:v2.x.

@vladvildanov
Copy link
Contributor

@xabbuh Thank you, it makes a lot of sense

@vladvildanov vladvildanov merged commit 0a92618 into predis:v2.x Jul 11, 2024
76 checks passed
@xabbuh xabbuh deleted the pr-1470 branch July 11, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss tillkruss approved these changes

@vladvildanov vladvildanov vladvildanov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @coveralls @vladvildanov @tillkruss