Skip to content

Conversation

@mohorev
Copy link
Contributor

@mohorev mohorev commented Jun 28, 2024

Description:

When using the SMISMEMBER command, it has been observed that the client's prefix is ignored. This leads to incorrect membership checks within a set, as the key passed to the command does not include the prefix specified for the client.

Changes:

  • Updated the handling of the SMISMEMBER command to include the client's prefix in the key.
  • Added tests to verify correct behavior of the command with a prefix.

Additional Information:

Predis Version: v2.2.2

@mohorev mohorev requested a review from tillkruss as a code owner June 28, 2024 15:23
@coveralls
Copy link

Coverage Status

coverage: 80.293% (+0.004%) from 80.289%
when pulling b376c9b on mohorev:smismember-key
into cbef710 on predis:v2.x.

@tillkruss
Copy link
Member

@vladvildanov Good?

@mohorev
Copy link
Contributor Author

mohorev commented Jul 2, 2024

@tillkruss @vladvildanov I rebased my branch from v2.x because code style issues are already fixed in the base branch.

@coveralls
Copy link

Coverage Status

coverage: 80.293% (+0.004%) from 80.289%
when pulling 0aa0d70 on mohorev:smismember-key
into c5fdfc8 on predis:v2.x.

@tillkruss tillkruss added the bug label Jul 2, 2024
@tillkruss tillkruss merged commit 5d22ed7 into predis:v2.x Jul 2, 2024
@mohorev mohorev deleted the smismember-key branch July 3, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants