Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for hash field expiration commands #1456

Merged
merged 19 commits into from
Oct 15, 2024
Merged

Added support for hash field expiration commands #1456

merged 19 commits into from
Oct 15, 2024

Conversation

vladvildanov
Copy link
Contributor

@vladvildanov vladvildanov commented Apr 29, 2024 •
edited
Loading

This PR adds new commands operates on hash field expiration functionality

@vladvildanov vladvildanov requested a review from tillkruss as a code owner April 29, 2024 12:37
@vladvildanov vladvildanov requested a review from a team April 29, 2024 12:37
@vladvildanov vladvildanov marked this pull request as draft April 29, 2024 12:37
@vladvildanov
Copy link
Contributor Author

vladvildanov commented Apr 29, 2024 •
edited
Loading

PR still on draft, until:

  • Redis unstable docker image will support given functionality

@coveralls
Copy link

coveralls commented Apr 29, 2024 •
edited
Loading

Coverage Status

coverage: 80.522% (+0.09%) from 80.429%
when pulling 756efc7 on vladvildanov:vv-hash-field-expiration
into 0a92618 on predis:v2.x.

@vladvildanov vladvildanov force-pushed the vv-hash-field-expiration branch from cbc69b4 to b59f5fb Compare May 17, 2024 09:21
gerzse
gerzse reviewed May 17, 2024
View reviewed changes
gerzse
gerzse reviewed May 21, 2024
View reviewed changes
Copy link

@gerzse gerzse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can't use the "Approve" button, but consider this approved from my side.

@vladvildanov vladvildanov force-pushed the vv-hash-field-expiration branch from 82eab7a to c522417 Compare June 5, 2024 14:05
@vladvildanov vladvildanov marked this pull request as ready for review June 11, 2024 09:36
@vladvildanov vladvildanov requested a review from gerzse July 5, 2024 13:37
@vladvildanov vladvildanov requested a review from a team July 31, 2024 08:30
@jdecool
Copy link

jdecool commented Sep 12, 2024

Very interesting.

Can it be merged soon ?

@rusowyler
Copy link

Hey guys! Can we merge this PR soon?

@tillkruss tillkruss merged commit 8fbd34c into predis:v2.x Oct 15, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss tillkruss approved these changes

@sazzad16 sazzad16 sazzad16 approved these changes

@gerzse gerzse Awaiting requested review from gerzse

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vladvildanov @coveralls @jdecool @rusowyler @tillkruss @gerzse @sazzad16