explicitly mark nullable parameters as nullable #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
requested changes
Mar 29, 2024
xabbuh
force-pushed
the
php-8.4
branch
4 times, most recently
from
3c841d7 to
d3d869e
Compare
|
@tillkruss done, should I also fix the reported code style issues? |
|
In a separate PR, sure! 👍 |
tillkruss
requested changes
Apr 1, 2024
|
Any blocker to merge this? That's remove some failures in the CI of Symfony. 🙏 |
|
@tillkruss sorry for the noise. Predis is the last dep of Symfony that didn't fix this issue. I'd love being able to close this topic 🙏 |
|
@tillkruss is there anything we could do to help get this PR merged? 🙏 |
|
@nicolas-grekas Yes, sorry for the delay. |
|
Thank you for merging! 😊 |
|
When will this release? |
11 tasks
This was referenced Nov 18, 2024
|
@tillkruss Any chance we can have |
1 task
|
@crynobone Yeah good idea, heaps of changes queued up: v2.2.2...v2.x |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not doing this will be deprecated in PHP 8.4 (see e.g. https://github.com/symfony/symfony/actions/runs/8459191951/job/23175036483?pr=54426#step:8:2335)