explicitly mark nullable parameters as nullable#1448
Conversation
tillkruss
left a comment
tillkruss
left a comment
There was a problem hiding this comment.
Can you also add 8.4 to the tests.yml so we can see these run?
xabbuh
force-pushed
the
php-8.4
branch
4 times, most recently
from
3c841d7 to
d3d869e
Compare
|
@tillkruss done, should I also fix the reported code style issues? |
|
In a separate PR, sure! 👍 |
|
Any blocker to merge this? That's remove some failures in the CI of Symfony. 🙏 |
|
@tillkruss sorry for the noise. Predis is the last dep of Symfony that didn't fix this issue. I'd love being able to close this topic 🙏 |
|
@tillkruss is there anything we could do to help get this PR merged? 🙏 |
|
@nicolas-grekas Yes, sorry for the delay. |
|
Thank you for merging! 😊 |
|
When will this release? |
|
@tillkruss Any chance we can have |
|
@crynobone Yeah good idea, heaps of changes queued up: v2.2.2...v2.x |
6 participants
not doing this will be deprecated in PHP 8.4 (see e.g. https://github.com/symfony/symfony/actions/runs/8459191951/job/23175036483?pr=54426#step:8:2335)