Improved pipeline abstractions#1438
Merged
Merged
Conversation
tillkruss
reviewed
Mar 4, 2024
Member
tillkruss
left a comment
tillkruss
left a comment
There was a problem hiding this comment.
This is excellent. Does it have any implication with Relay, since write() isn't supported?
Contributor
Author
|
@tillkruss I don't think it has, Relay is an another layer above connection that does not provide an API for direct socket communication. Also, RelayPipeline overrides |
tillkruss
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to enhance pipelines to make them "real" pipelines. For now all commands are still pushed into socket one by one. Instead of this, the behaviour was changed to create a buffer from pipelined commands and push them all at once.