Improved connection handshake session #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladvildanov
changed the title
vladvildanov
force-pushed
the
vv-pipeline-on-connection-commands
branch
from
86a541b to
60f778c
Compare
vladvildanov
force-pushed
the
vv-pipeline-on-connection-commands
branch
from
60f778c to
10bb01b
Compare
Contributor
Author
|
@tillkruss Review required |
Contributor
Author
|
@tillkruss This PR is blocked by #1437 so it doesn't look like a total mess |
Member
|
Can we rebase after merging the styling changes first? Hard to read otherwise. |
Contributor
Author
|
@tillkruss Done! |
tillkruss
approved these changes
Mar 2, 2024
tillkruss
approved these changes
Mar 2, 2024
tillkruss
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1422
This PR changes on-connection behaviour by using fewer commands during handshake
Additional enhancements:
CommandInterfacewithserializeCommand()method that returns RESP representation of command. According to Information Expert pattern Command object should provides it's serialized representation instead of Connection object.NodeConnectionInterfacewithwrite()method that writes serialized command directly into resource. This method existed before but was protected.NodeConnectionInterfacewithgetClientId()method that returns CLIENT ID assigned by Redis server for current connection.