Fixed Relay objects structure #1419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks great! |
tillkruss
approved these changes
Nov 29, 2023
Member
|
@vladvildanov Should we merge this into v3 directly? |
Contributor
Author
|
@tillkruss If you don't mind, I created a separate branch for whole relay improvement "feature", my plan is to push it into 3.x when it's will be completely finished |
Member
Sure thing 👍 |
tillkruss
added a commit
that referenced
this pull request
Dec 28, 2023
* Fixed Relay objects structure (#1419) * Added OSS cluster tests (#1421) --------- Co-authored-by: Till Krüss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements:
RelayConnectionnow is implementation ofNodeConnectionInterface, not a children ofStreamConnection.RelayFactory, separate object that responsible forRelayConnectioninstantiating. Single factory for all connection types makes it's harder to maintain and requires additionalifstatements per type if logic is differ, which leads to changes into existing code.#1292