Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Relay objects structure #1419

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Fixed Relay objects structure #1419

merged 4 commits into from
Dec 5, 2023

Conversation

vladvildanov
Copy link
Contributor

@vladvildanov vladvildanov commented Nov 22, 2023 •
edited
Loading

Enhancements:

  1. RelayConnection now is implementation of NodeConnectionInterface, not a children of StreamConnection.
  2. Added RelayFactory, separate object that responsible for RelayConnection instantiating. Single factory for all connection types makes it's harder to maintain and requires additional if statements per type if logic is differ, which leads to changes into existing code.
  3. Test coverage increased, including feature tests.

#1292

@vladvildanov vladvildanov requested a review from chayim November 22, 2023 08:47
@tillkruss
Copy link
Member

This looks great!

@tillkruss
Copy link
Member

@vladvildanov Should we merge this into v3 directly?

@vladvildanov
Copy link
Contributor Author

@tillkruss If you don't mind, I created a separate branch for whole relay improvement "feature", my plan is to push it into 3.x when it's will be completely finished

@tillkruss
Copy link
Member

@tillkruss If you don't mind, I created a separate branch for whole relay improvement "feature", my plan is to push it into 3.x when it's will be completely finished

Sure thing 👍

@tillkruss tillkruss merged commit 7a5c881 into predis:feature/relay-improvements Dec 5, 2023
tillkruss added a commit that referenced this pull request Dec 28, 2023
@vladvildanov @tillkruss
Improved Relay integration (#1423)
d56e327 
* Fixed Relay objects structure (#1419)
* Added OSS cluster tests (#1421)

---------

Co-authored-by: Till Krüss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss tillkruss approved these changes

@chayim chayim Awaiting requested review from chayim

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladvildanov @tillkruss