Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 3.0 changelog and documentation update #1393

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Added 3.0 changelog and documentation update #1393

merged 2 commits into from
Nov 14, 2023

Conversation

vladvildanov
Copy link
Contributor

No description provided.

@vladvildanov vladvildanov requested a review from chayim August 30, 2023 10:52
@vladvildanov vladvildanov mentioned this pull request Aug 30, 2023
Merged
@vladvildanov
Copy link
Contributor Author

@uglide Needs your review on it

@tillkruss
Copy link
Member

What commits does this cover?

@vladvildanov
Copy link
Contributor Author

@tillkruss I linked GA issues in README, so it covers exactly this PR's

@chayim
Copy link
Contributor

chayim commented Oct 22, 2023

@vladvildanov There's no reason for the CI failure - purely from the READMEs. Can you please have a look.

chayim
chayim reviewed Oct 22, 2023
View reviewed changes
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the content. However, I'd still like to see CI investigated. That can clearly be a separate PR to keep it surgical. There's no (logical) reason these README changes should have impacted.

@vladvildanov
Copy link
Contributor Author

@chayim It's failing because of redis-stack-server:latest image was updated. Already been fixed within this PR

#1348

@coveralls
Copy link

Coverage Status

coverage: 82.431%. remained the same
when pulling ffac69a on vladvildanov:vv-3.0-changelogs-documentation
into 662fdb9 on predis:v3.x.

@vladvildanov vladvildanov merged commit eabd115 into predis:v3.x Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim chayim left review comments

@tillkruss tillkruss Awaiting requested review from tillkruss

Assignees
No one assigned
Labels
maintenance
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladvildanov @tillkruss @chayim @coveralls