Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter opt out for setinfo commands #1370

Open
wants to merge 12 commits into
base: v2.x
Choose a base branch
from

Conversation

kylekatarnls
Copy link

@kylekatarnls kylekatarnls commented Aug 24, 2023

This gives an opt-out for users who don't need the bootstrap SETINFO and want to remove them for performance or other reasons.

@kylekatarnls kylekatarnls force-pushed the feature/setinfo-opt-out branch from 7a83390 to 7f9fd68 Compare August 24, 2023 09:34
Copy link

@Okhoshi Okhoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems overkill to have 2 parameters to control this

@kylekatarnls
Copy link
Author

Fix for #1347 (comment)

@tillkruss tillkruss self-assigned this Aug 24, 2023
tillkruss
tillkruss previously approved these changes Aug 24, 2023
@kylekatarnls
Copy link
Author

@kylekatarnls kylekatarnls requested a review from tillkruss August 24, 2023 18:55
tillkruss
tillkruss previously approved these changes Aug 24, 2023
@vladvildanov
Copy link
Contributor

Test coverage?

@kylekatarnls
Copy link
Author

Test added. You need to "Approve and run workflows" to trigger tests and get result from coveralls

@kylekatarnls
Copy link
Author

Redis 7 errors unrelated (might have been introduced by last week update of Redis 7.2)

Can be verified with #1372

@coveralls
Copy link

Coverage Status

coverage: 78.183% (+0.02%) from 78.167% when pulling 5cb1702 on kylekatarnls:feature/setinfo-opt-out into 16bdd83 on predis:v2.x.

@vladvildanov vladvildanov requested review from BafS, Okhoshi and chayim and removed request for BafS and Okhoshi August 28, 2023 11:18
Copy link
Member

@tillkruss tillkruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify client_* options.

@tillkruss
Copy link
Member

No, why do we need client name/version to be configurable at all? It should always be Predis, no?

@vladvildanov
Copy link
Contributor

@tillkruss I believe @chayim knows more than me about that. It looks like clients should be able to advertise their own products this way. F.E if magento uses predis as Redis client, they can override this values, so cloud instances can collect this kind of data about magento clients.

@chayim
Copy link
Contributor

chayim commented Sep 6, 2023

The reason for allowing setting names and versions is to enable "whatever people want to create". It's entirely possible to build client solutions on top of existing clients (nredisstack and stackexchange.redis for example). This is the vision of how these things would be used.

It also allows (same example) for a client to advertise something like:
Name: Foo [predis]

Thus, sharing all.

@tillkruss
Copy link
Member

@kylekatarnls: I'll merge a quick fix in #1399, because #1398 is making this more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants