Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for XREADGROUP command #1327

Merged
merged 25 commits into from
Jul 26, 2023

Conversation

vladvildanov
Copy link
Contributor

Closes #1326

@vladvildanov vladvildanov requested review from chayim and a team June 20, 2023 13:03
@vladvildanov vladvildanov requested a review from tillkruss as a code owner June 20, 2023 13:03
tillkruss
tillkruss previously approved these changes Jun 20, 2023
vladvildanov and others added 6 commits June 21, 2023 12:00
* Fixed bug with incorrect multiple words processing

* Convert subcommand string to lower case

* Update SubcommandStrategyResolver.php

* Added test coverage

* Codestyle fixes

---------

Co-authored-by: Till Krüss <[email protected]>
@coveralls
Copy link

coveralls commented Jun 21, 2023

Coverage Status

coverage: 82.16% (+0.04%) from 82.124% when pulling 8254898 on vladvildanov:vv-1326-xreadgroup-support into a5cc48d on predis:v3.x.

@vladvildanov vladvildanov requested a review from tillkruss June 21, 2023 11:22
@vladvildanov vladvildanov force-pushed the vv-1326-xreadgroup-support branch from bbe014d to bf75602 Compare June 21, 2023 12:39
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get more tests in place. XREADGROUP accepts key [key ...] id [id...] , so I think we're missing at least one test case (multiple if you think of ID as a list).

@vladvildanov
Copy link
Contributor Author

@chayim Done!

@vladvildanov vladvildanov requested a review from chayim July 4, 2023 14:03
@vladvildanov vladvildanov changed the base branch from v2.x to v3.x July 26, 2023 13:33
@vladvildanov vladvildanov merged commit b18c56e into predis:v3.x Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Add support for missing redis command XREADGROUP
4 participants