Push notifications support #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayim
reviewed
Jun 29, 2023
|
|
||
| foreach ($push as $notification) { | ||
| if ((null !== $notification) && $notification->getDataType() === PushResponseInterface::MESSAGE_DATA_TYPE) { | ||
| if ($notification[1] === 'control' && $notification[2] === 'terminate') { |
There was a problem hiding this comment.
How about moving control and terminate into things we can import + test against (const-y)
chayim
reviewed
Jun 29, 2023
| // Data types should be changed in near future. Instead of Message data type it should be one of kind data types. | ||
|
|
||
| $dispatcher->attachCallback( | ||
| PushResponseInterface::MESSAGE_DATA_TYPE, |
chayim
reviewed
Jun 29, 2023
chayim
reviewed
Jun 29, 2023
| @@ -1048,7 +1048,7 @@ public function testPubSubLoopWithoutArgumentsReturnsPubSubConsumer(): void | |||
| { | |||
| $client = new Client(); | |||
|
|
|||
| $this->assertInstanceOf('Predis\PubSub\Consumer', $client->pubSubLoop()); | |||
| $this->assertInstanceOf('Predis\Consumer\PubSub\Consumer', $client->pubSubLoop()); | |||
There was a problem hiding this comment.
TBH I preferred the old pathing. It looks prettier. Any way to approach it?
There was a problem hiding this comment.
@chayim It was done to keep different entities within the same domain. There are a lot of "Consumers": PubSub, Sharded PubSub, Push Notifications. All of them "consume" messages from server. IMHO, it's better to create a separate place where we can keep all entities related to this domain, then spreading them across whole library.
chayim
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1308