Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve merge conflicts between v2.x and main #1247

Merged
merged 45 commits into from
Apr 3, 2023

Conversation

vladvildanov
Copy link
Contributor

vladvildanov and others added 30 commits January 25, 2023 07:59
* Added support for SORT_RO command

* Codestyle fixes

* Added command description

---------

Co-authored-by: Vladyslav Vildanov <[email protected]>
* Added support for container commands FUNCTION LOAD, FUNCTION DELETE and FCALL

* Changed ContainerInterface and AbstractContainer

* Re-implement logic of abstract methods

---------

Co-authored-by: Vladyslav Vildanov <[email protected]>
…redis#1168)

* Add option for disabling reads to slaves in replication topologies

(cherry picked from commit e132c31)

* remove empty line

---------

Co-authored-by: Till Krüss <[email protected]>
* match `MasterSlaveReplication`

also the name of this method 😬

* Update SentinelReplication.php
* Added CODEOWNERS file

* Update CODEOWNERS

* Applied whole Redis commands path as @vladvildanov codeowner

* Set @predis/team as Redis commands codeowners

* Update CODEOWNERS

---------

Co-authored-by: Vladyslav Vildanov <[email protected]>
Co-authored-by: Till Krüss <[email protected]>
* Deprecate webdis and phpiredis

* remove space
vladvildanov and others added 14 commits March 14, 2023 10:11
…redis#1193)

* Added support for ACL GETUSER, SETUSER, DRYRUN commands

* Change test to support Redis > 6.0.0

* Removed selectors check
* Added missing stream key prefixes

* Tested stream command key prefixing
@vladvildanov vladvildanov requested review from tillkruss, chayim and a team April 3, 2023 09:27
Copy link

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait on @tillkruss to merge obvi

@vladvildanov
Copy link
Contributor Author

@chayim It's not a main PR, it's just resolving conflicts between v2.x and main. After this one will be merged I can create a release PR

@vladvildanov vladvildanov merged commit af34718 into predis:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants