Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fclose() being called on invalid stream resource #1199

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Fix fclose() being called on invalid stream resource #1199

merged 1 commit into from
Mar 23, 2023

Conversation

p-jahn
Copy link

@p-jahn p-jahn commented Mar 22, 2023

fixes fclose(): supplied resource is not a valid stream resource which (as per my understanding) may occur since PHP 8.1 if the resource was already closed (or is otherwise invalid)

@tillkruss tillkruss added the bug label Mar 23, 2023
@tillkruss tillkruss merged commit 1bd5043 into predis:main Mar 23, 2023
@p-jahn p-jahn deleted the sc-close-resource-check branch March 24, 2023 21:24
@jayesh-razorpay jayesh-razorpay mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss tillkruss approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-jahn @tillkruss