Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream commands (e.g. xadd) are not applying the key prefix #1050

Closed
jessarcher opened this issue Jan 31, 2023 · 3 comments · Fixed by #1051
Closed

Stream commands (e.g. xadd) are not applying the key prefix #1050

jessarcher opened this issue Jan 31, 2023 · 3 comments · Fixed by #1051
Labels
bug

Comments

@jessarcher
Copy link
Contributor

Describe the bug
Stream commands like xadd are not applying the key prefix.

To Reproduce
Steps to reproduce the behavior:

  1. Initialize Predis\Client with a prefix (e.g. 'sample:').
  2. Call the xadd method with a key (e.g. 'my-stream-key').
  3. List the keys and see that the new key is missing the configured prefix.

Expected behavior
The configured key prefix should be prepended to the key provided to xadd.

Versions (please complete the following information):

  • Predis: 2.1.1
  • PHP: 8.2.1
  • Redis Server: 7.0.5
  • OS: Fedora 37

Code sample

$client = new \Predis\Client(null, ['prefix' => 'sample:']);

$client->xadd('my-stream-key', ['foo' => 'bar']);

$client->keys('*'); // []

$client->executeRaw(['KEYS', '*']); // ['my-stream-key']

$client->xrange('my-stream-key', '-', '+'); // Returns the stream, indicating that xrange probably ignores the prefix too.

Additional context
The issue does not exist with other data structures using the same client instance above.
@jessarcher jessarcher added the bug label Jan 31, 2023
@vladvildanov vladvildanov mentioned this issue Jan 31, 2023
Merged
@vladvildanov
Copy link
Contributor

vladvildanov commented Jan 31, 2023 •
edited
Loading

@jessarcher Thank you for your report! Just added a PR to fix this issue. Please make sure you're using correct prefix pattern, prefixes with : occurs WRONGTYPE Operation against a key holding the wrong kind of value redis server error for xadd command.

Try this one:

$client = new \Predis\Client(null, ['prefix' => 'sample-']);

$client->xadd('my-stream-key', ['foo' => 'bar']);

$client->xrange('my-stream-key', '-', '+');

@jessarcher
Copy link
Contributor Author

Thank you @vladvildanov! 🙏

Just as a heads up, the sample: prefix in my reproduction example comes from this project's readme: https://github.com/predis/predis#client-configuration.

@vladvildanov
Copy link
Contributor

@jessarcher Sure, in most cases prefix pattern doesn't matter, but in this it is 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added stream commands to KeyPrefixProcessor vladvildanov/predis
2 participants
@jessarcher @vladvildanov