Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in v2.1.0 #1016

Closed
driesvints opened this issue Jan 17, 2023 · 4 comments · Fixed by #1018
Closed

Breaking change in v2.1.0 #1016

driesvints opened this issue Jan 17, 2023 · 4 comments · Fixed by #1018
Labels

Comments

@driesvints
Copy link
Contributor

Describe the bug
Since v2.1.0 we're experiencing a breaking change when running zinterstore and passing an array as weights: https://github.com/laravel/framework/actions/runs/3936474461/jobs/6734736234#step:9:102

Builds of Laravel framework and every PR are now failing. Would appreciate some quick action on this if possible. I wasn't able to determine how to solve this.

If the below isn't considered appropriate usage then can you point to some docs on how to use this method call?

To Reproduce
Steps to reproduce the behavior:

$redis->zinterstore('output2', ['set1', 'set2'], [
    'weights' => [3, 2],
    'aggregate' => 'sum',
]);

Expected behavior
Before this worked and no errors showed.

Versions (please complete the following information):

  • Predis: [e.g. 2.1.0]
  • PHP [e.g. 8.0.27]
  • Redis Server [e.g. 5.3.7]
  • OS [e.g. Ubuntu 22.04]

Code sample
See above.

Additional context
Add any other context about the problem here.

@driesvints driesvints added the bug label Jan 17, 2023
@tillkruss
Copy link
Member

This must have not been covered by tests. @vladvildanov can you add a test and fix the breaking change?

@vladvildanov
Copy link
Contributor

@tillkruss Will have a look tomorrow morning

@tillkruss
Copy link
Member

@tillkruss Will have a look tomorrow morning

That's too late, I fixed it.

@driesvints
Copy link
Contributor Author

That fixed it, thanks @tillkruss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants