Skip to content

Commit 7bf1f6e

Browse files
messikillerheqimingtillkrussvladvildanov
authored
optimize redis cluster slotmap with compact slot range object (#1493)
Co-authored-by: heqiming <[email protected]> Co-authored-by: Till Krüss <[email protected]> Co-authored-by: Vladyslav Vildanov <[email protected]>
1 parent 067b051 commit 7bf1f6e

File tree

6 files changed

+1226
-17
lines changed

6 files changed

+1226
-17
lines changed

‎src/Cluster/NullSlotRange.php

+40
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
<?php
2+
3+
/*
4+
* This file is part of the Predis package.
5+
*
6+
* (c) 2009-2020 Daniele Alessandri
7+
* (c) 2021-2025 Till Krüss
8+
*
9+
* For the full copyright and license information, please view the LICENSE
10+
* file that was distributed with this source code.
11+
*/
12+
13+
namespace Predis\Cluster;
14+
15+
/**
16+
* Represents the gap between slot ranges.
17+
*/
18+
class NullSlotRange extends SlotRange
19+
{
20+
public function __construct(int $start, int $end)
21+
{
22+
parent::__construct($start, $end, '');
23+
}
24+
25+
/**
26+
* {@inheritDoc}
27+
*/
28+
public function toArray(): array
29+
{
30+
return [];
31+
}
32+
33+
/**
34+
* {@inheritDoc}
35+
*/
36+
public function count(): int
37+
{
38+
return 0;
39+
}
40+
}

‎src/Cluster/SimpleSlotMap.php

+209
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,209 @@
1+
<?php
2+
3+
/*
4+
* This file is part of the Predis package.
5+
*
6+
* (c) 2009-2020 Daniele Alessandri
7+
* (c) 2021-2025 Till Krüss
8+
*
9+
* For the full copyright and license information, please view the LICENSE
10+
* file that was distributed with this source code.
11+
*/
12+
13+
namespace Predis\Cluster;
14+
15+
use ArrayAccess;
16+
use ArrayIterator;
17+
use Countable;
18+
use IteratorAggregate;
19+
use OutOfBoundsException;
20+
use Predis\Connection\NodeConnectionInterface;
21+
use ReturnTypeWillChange;
22+
use Traversable;
23+
24+
/**
25+
* Slot map for redis-cluster.
26+
*/
27+
class SimpleSlotMap implements ArrayAccess, IteratorAggregate, Countable
28+
{
29+
private $slots = [];
30+
31+
/**
32+
* Checks if the given slot is valid.
33+
*
34+
* @param int $slot Slot index.
35+
*
36+
* @return bool
37+
*/
38+
public static function isValid($slot)
39+
{
40+
return $slot >= 0x0000 && $slot <= 0x3FFF;
41+
}
42+
43+
/**
44+
* Checks if the given slot range is valid.
45+
*
46+
* @param int $first Initial slot of the range.
47+
* @param int $last Last slot of the range.
48+
*
49+
* @return bool
50+
*/
51+
public static function isValidRange($first, $last)
52+
{
53+
return $first >= 0x0000 && $first <= 0x3FFF && $last >= 0x0000 && $last <= 0x3FFF && $first <= $last;
54+
}
55+
56+
/**
57+
* Resets the slot map.
58+
*/
59+
public function reset()
60+
{
61+
$this->slots = [];
62+
}
63+
64+
/**
65+
* Checks if the slot map is empty.
66+
*
67+
* @return bool
68+
*/
69+
public function isEmpty()
70+
{
71+
return empty($this->slots);
72+
}
73+
74+
/**
75+
* Returns the current slot map as a dictionary of $slot => $node.
76+
*
77+
* The order of the slots in the dictionary is not guaranteed.
78+
*
79+
* @return array
80+
*/
81+
public function toArray()
82+
{
83+
return $this->slots;
84+
}
85+
86+
/**
87+
* Returns the list of unique nodes in the slot map.
88+
*
89+
* @return array
90+
*/
91+
public function getNodes()
92+
{
93+
return array_keys(array_flip($this->slots));
94+
}
95+
96+
/**
97+
* Assigns the specified slot range to a node.
98+
*
99+
* @param int $first Initial slot of the range.
100+
* @param int $last Last slot of the range.
101+
* @param NodeConnectionInterface|string $connection ID or connection instance.
102+
*
103+
* @throws OutOfBoundsException
104+
*/
105+
public function setSlots($first, $last, $connection)
106+
{
107+
if (!static::isValidRange($first, $last)) {
108+
throw new OutOfBoundsException("Invalid slot range $first-$last for `$connection`");
109+
}
110+
111+
$this->slots += array_fill($first, $last - $first + 1, (string) $connection);
112+
}
113+
114+
/**
115+
* Returns the specified slot range.
116+
*
117+
* @param int $first Initial slot of the range.
118+
* @param int $last Last slot of the range.
119+
*
120+
* @return array
121+
*/
122+
public function getSlots($first, $last)
123+
{
124+
if (!static::isValidRange($first, $last)) {
125+
throw new OutOfBoundsException("Invalid slot range $first-$last");
126+
}
127+
128+
return array_intersect_key($this->slots, array_fill($first, $last - $first + 1, null));
129+
}
130+
131+
/**
132+
* Checks if the specified slot is assigned.
133+
*
134+
* @param int $slot Slot index.
135+
*
136+
* @return bool
137+
*/
138+
#[ReturnTypeWillChange]
139+
public function offsetExists($slot)
140+
{
141+
return isset($this->slots[$slot]);
142+
}
143+
144+
/**
145+
* Returns the node assigned to the specified slot.
146+
*
147+
* @param int $slot Slot index.
148+
*
149+
* @return string|null
150+
*/
151+
#[ReturnTypeWillChange]
152+
public function offsetGet($slot)
153+
{
154+
return $this->slots[$slot] ?? null;
155+
}
156+
157+
/**
158+
* Assigns the specified slot to a node.
159+
*
160+
* @param int $slot Slot index.
161+
* @param NodeConnectionInterface|string $connection ID or connection instance.
162+
*
163+
* @return void
164+
*/
165+
#[ReturnTypeWillChange]
166+
public function offsetSet($slot, $connection)
167+
{
168+
if (!static::isValid($slot)) {
169+
throw new OutOfBoundsException("Invalid slot $slot for `$connection`");
170+
}
171+
172+
$this->slots[(int) $slot] = (string) $connection;
173+
}
174+
175+
/**
176+
* Returns the node assigned to the specified slot.
177+
*
178+
* @param int $slot Slot index.
179+
*
180+
* @return void
181+
*/
182+
#[ReturnTypeWillChange]
183+
public function offsetUnset($slot)
184+
{
185+
unset($this->slots[$slot]);
186+
}
187+
188+
/**
189+
* Returns the current number of assigned slots.
190+
*
191+
* @return int
192+
*/
193+
#[ReturnTypeWillChange]
194+
public function count()
195+
{
196+
return count($this->slots);
197+
}
198+
199+
/**
200+
* Returns an iterator over the slot map.
201+
*
202+
* @return Traversable<int, string>
203+
*/
204+
#[ReturnTypeWillChange]
205+
public function getIterator()
206+
{
207+
return new ArrayIterator($this->slots);
208+
}
209+
}

0 commit comments

Comments
 (0)