shorten code; add comment

tillkruss · web-flow · commit 28b2b575f94b · 2024-03-04T09:11:36.000-08:00
diff --git a/src/Connection/Replication/SentinelReplication.php b/src/Connection/Replication/SentinelReplication.php
@@ -426,12 +426,9 @@ protected function querySentinelForSlaves(NodeConnectionInterface $sentinel, $se
                 continue;
             }
 
-            if (isset($slave[31])) {
-                $masterLinkStatus = $slave[31];
-
-                if ($masterLinkStatus !== 'ok') {
-                    continue;
-                }
+            // ensure `master-link-status` is ok
+            if (isset($slave[31]) && $slave[31] === 'err') {
+                continue;
             }
 
             $slaves[] = [

Original file line number	Diff line number	Diff line change
`@@ -426,12 +426,9 @@ protected function querySentinelForSlaves(NodeConnectionInterface $sentinel, $se`
`426`	`426`	`continue;`
`427`	`427`	`}`
`428`	`428`
`429`		`- if (isset($slave[31])) {`
`430`		`- $masterLinkStatus = $slave[31];`
`431`		`-`
`432`		`- if ($masterLinkStatus !== 'ok') {`
`433`		`- continue;`
`434`		`- }`
	`429`	+ // ensure `master-link-status` is ok
	`430`	`+ if (isset($slave[31]) && $slave[31] === 'err') {`
	`431`	`+ continue;`
`435`	`432`	`}`
`436`	`433`
`437`	`434`	`$slaves[] = [`