Fixed bug with null arguments in SET command (#1470)

vladvildanov · web-flow · commit 274e0c17cde7 · 2024-07-09T14:10:58.000+03:00
diff --git a/src/Command/Redis/SET.php b/src/Command/Redis/SET.php
@@ -26,4 +26,10 @@ public function getId()
     {
         return 'SET';
     }
+
+    public function setArguments(array $arguments)
+    {
+        parent::setArguments($arguments);
+        $this->filterArguments();
+    }
 }
diff --git a/tests/Predis/Command/Redis/SET_Test.php b/tests/Predis/Command/Redis/SET_Test.php
@@ -175,6 +175,19 @@ public function testSetStringValueWithModifierXX(): void
         $this->assertNull($redis->set('foofoo', 'barbar', 'XX'));
     }
 
+    /**
+     * @group connected
+     * @requiresRedisVersion >= 2.6.12
+     */
+    public function testSetStringDoesNotFailWithExplicitlySetNullArguments(): void
+    {
+        $redis = $this->getClient();
+
+        $this->assertEquals(
+            'OK', $redis->set('foo', 'barbar', null, null, null)
+        );
+    }
+
     /**
      * @group connected
      * @group cluster

Original file line number	Diff line number	Diff line change
`@@ -26,4 +26,10 @@ public function getId()`
`26`	`26`	`{`
`27`	`27`	`return 'SET';`
`28`	`28`	`}`
	`29`	`+`
	`30`	`+ public function setArguments(array $arguments)`
	`31`	`+ {`
	`32`	`+ parent::setArguments($arguments);`
	`33`	`+ $this->filterArguments();`
	`34`	`+ }`
`29`	`35`	`}`