match MasterSlaveReplication (#1175)

tillkruss · web-flow · commit 26c625230fa5 · 2023-02-21T08:30:43.000-08:00
* match `MasterSlaveReplication`

also the name of this method 😬

* Update SentinelReplication.php
diff --git a/src/Connection/Replication/SentinelReplication.php b/src/Connection/Replication/SentinelReplication.php
@@ -509,13 +509,15 @@ public function getSlaves()
     /**
      * Returns a random slave.
      *
-     * @return NodeConnectionInterface
+     * @return NodeConnectionInterface|null
      */
     protected function pickSlave()
     {
-        if ($slaves = $this->getSlaves()) {
-            return $slaves[rand(1, count($slaves)) - 1];
-        }
+        $slaves = $this->getSlaves();
+
+        return $slaves
+            ? $slaves[rand(1, count($slaves)) - 1]
+            : null;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -509,13 +509,15 @@ public function getSlaves()`
`509`	`509`	`/**`
`510`	`510`	`* Returns a random slave.`
`511`	`511`	`*`
`512`		`- * @return NodeConnectionInterface`
	`512`	`+ * @return NodeConnectionInterface\|null`
`513`	`513`	`*/`
`514`	`514`	`protected function pickSlave()`
`515`	`515`	`{`
`516`		`- if ($slaves = $this->getSlaves()) {`
`517`		`- return $slaves[rand(1, count($slaves)) - 1];`
`518`		`- }`
	`516`	`+ $slaves = $this->getSlaves();`
	`517`	`+`
	`518`	`+ return $slaves`
	`519`	`+ ? $slaves[rand(1, count($slaves)) - 1]`
	`520`	`+ : null;`
`519`	`521`	`}`
`520`	`522`
`521`	`523`	`/**`