Update multiple-perpendicular-flaps picture and documentation#511
Merged
MakisH merged 4 commits intoprecice:developfrom Apr 4, 2024
MakisH:update-multi-flaps-image
Merged
Update multiple-perpendicular-flaps picture and documentation#511MakisH merged 4 commits intoprecice:developfrom MakisH:update-multi-flaps-image
MakisH merged 4 commits intoprecice:developfrom
MakisH:update-multi-flaps-image
Conversation
davidscn
reviewed
Apr 4, 2024
MakisH
commented
Apr 4, 2024
Member
Author
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
I assume from the comments that this has been implicitly approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@davidscn had some issues reproducing this picture at some point, I hope that the additional details and the missing scaling factor helps.
This also changes the threshold for the size check to 750KB. I think that, back in the day, we set it to 250KB because is was easy to achieve, but I think we are suffering too much without a concrete reason. Some images are just larger, and here I want to show the details of the mesh.