Add a .gitignore and clean-up#477
Merged
MakisH merged 22 commits intoprecice:developfrom Mar 12, 2024
MakisH:gitignore
Merged
Conversation
Unintentionally deleted in #459 as a result of a wrong gitignore
Draft
Member
Thank you doing this, I think all the folders and files to be removed relating to |
Fujikawas
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignore, taking into account all solvers we currently support, and all rules we have already defined incleaning-tools.sh..gitignorefiles in special cases, mainly where we download files from external repositories:aste-turbine,heat-exchanger.Make/directory unintentionally deleted in Follow naming convention in partitioned heat conduction - FEniCS #459 and fixes the corresponding.gitignore. (cc @BenjaminRodenberg)Also adds a comments on instructions to do a deep clean, as at the moment all externally downloaded files, python virtual environments, and C++ code builds are not deleted by the cleaning scripts (and one generally should not need to delete them). I already tried extending the cleaning scripts for this purpose, but it was easy to make them unnecessarily more complex.
Also, general cleanup:
reference-datais renamed toreference-results(cc @valentin-seitz)solver-*directories, to avoid the expectedskippingmessages.@IshaanDesai @Fujikawas how do you like this change? Anything I have missed?
I did not really try running anything DUNE-related, but I guess it is covered.
closes #87