Skip to content

Add flow around controlled moving cylinder (coupling FMI with OpenFOAM)#474

Merged
MakisH merged 25 commits intoprecice:developfrom
uekerman:add-fmi-openfoam-case
Mar 13, 2024
Merged

Add flow around controlled moving cylinder (coupling FMI with OpenFOAM)#474
MakisH merged 25 commits intoprecice:developfrom
uekerman:add-fmi-openfoam-case

Conversation

@uekerman
Copy link
Copy Markdown
Member

@uekerman uekerman commented Mar 6, 2024 •
edited
Loading

I took the original case of @LeonardWilleke from https://doi.org/10.18419/darus-3549, ported it to v3, and made it "tutorials-ready" (shorter runtime, README, ...). We should make @LeonardWilleke a co-author when merging here.

I ran the case with the precompiled FMU, I did not try to recompile on any other system.

@uekerman uekerman added this to the v202403.0 milestone Mar 6, 2024
@uekerman uekerman self-assigned this Mar 6, 2024
@uekerman uekerman marked this pull request as ready for review March 7, 2024 12:16
@uekerman uekerman requested a review from MakisH March 7, 2024 12:19
MakisH
MakisH reviewed Mar 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first comments on the general tutorial aspects (looks good already, needs some minor cleanup).

I have not yet tried to run it, and I don't have the expertise to review the FMI part.

@MakisH MakisH mentioned this pull request Mar 11, 2024
Merged
@MakisH
Copy link
Copy Markdown
Member

MakisH commented Mar 11, 2024 •
edited
Loading

Update: I can run the case, even though it takes quite a while (I am already running for several minutes, and I am only at 10%). Is there anything we can do to speed it up, or just reduce the simulated time?

edit: Takes around 70min to complete on my laptop.

@uekerman
Copy link
Copy Markdown
Member Author

uekerman commented Mar 11, 2024

Update: I can run the case, even though it takes quite a while (I am already running for several minutes, and I am only at 10%). Is there anything we can do to speed it up, or just reduce the simulated time?

Writing in the README:

To reduce the overall runtime compared to the original contribution, this case uses a larger time step size 2.5e-3 (instead of 1e-3) and the controller switches on at t=2 (instead of t=40). Still, the scenario requires around an hour to complete.

I already tweaked there a lot. The original case ran overnight.

MakisH
MakisH reviewed Mar 11, 2024
View reviewed changes
@MakisH MakisH changed the title Add flow over controlled moving cylinder (coupling FMI with OpenFOAM) Add flow around controlled moving cylinder (coupling FMI with OpenFOAM) Mar 12, 2024
MakisH
MakisH approved these changes Mar 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the few open questions that might need more documentation (but definitely need help from @LeonardWilleke), this looks ready from my perspective.

@uekerman feel free to merge once everything is clear.

@MakisH MakisH merged commit 7481fcf into precice:develop Mar 13, 2024
@uekerman uekerman deleted the add-fmi-openfoam-case branch March 13, 2024 08:56
@uekerman uekerman mentioned this pull request Apr 4, 2024
Merged
@LeonardWilleke LeonardWilleke mentioned this pull request May 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MakisH MakisH MakisH approved these changes

+1 more reviewer

@LeonardWilleke LeonardWilleke LeonardWilleke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@uekerman uekerman

Labels

None yet

Projects

None yet

Milestone

v202403.0

Development

Successfully merging this pull request may close these issues.

3 participants

@uekerman @MakisH @LeonardWilleke