Skip to content

Port the dunefem solver for flow-over-heated-plate simulation for preCICE v3#470

Merged
Fujikawas merged 7 commits intodevelopfrom
port-dunefem-tutorial
Mar 21, 2024
Merged

Port the dunefem solver for flow-over-heated-plate simulation for preCICE v3#470
Fujikawas merged 7 commits intodevelopfrom
port-dunefem-tutorial

Conversation

@Fujikawas
Copy link
Copy Markdown
Member

The DUNE components of version 2.9 are used for test.

Copy link
Copy Markdown
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Looks good 👍 Only one minor comment from my side. I did not run this tutorial.

@fsimonis fsimonis requested a review from uekerman March 20, 2024 10:36
Copy link
Copy Markdown
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can run the case and the results look good.

I added a venv here. FYI @MakisH then we don't have to install dune-fem in the VM.

@Fujikawas Fujikawas merged commit 383e824 into develop Mar 21, 2024
@Fujikawas Fujikawas deleted the port-dunefem-tutorial branch March 21, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants