Merged
Conversation
The format is the same as precice/precice
MakisH
approved these changes
Mar 5, 2024
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Makes sense and is helpful, thanks!
We are using a different .clang-format in the OpenFOAM adapter (which we could also use here for the OpenFOAM files), but let's rather keep one central file, same as preCICE. In any case, formatting OpenFOAM source files is an upstream issue.
Let's merge this before we start getting conflicts in other PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds clang-format and autopep8 pre-commit hooks and applies the formatting.
Also, the markdownlint hook doesn't work on Ubuntu 20.04 as @uekerman found out. I reverted to v0.30 which is known to work.
Next step would be to replace individual workflows with a pre-commit hook workflow.