Skip to content

Add error computation for partitioned-heat-conduction OpenFOAM solver#449

Merged
MakisH merged 2 commits intodevelopfrom
add-error
Mar 11, 2024
Merged

Add error computation for partitioned-heat-conduction OpenFOAM solver#449
MakisH merged 2 commits intodevelopfrom
add-error

Conversation

@davidscn
Copy link
Copy Markdown
Member

@davidscn davidscn commented Jan 24, 2024 •
edited
Loading

To help testing and comparing.

Related to #445

In our tutorials, with OpenFOAM - OpenFOAM, I get

Dirichlet:

Error metrics at t = 1s:
l2 error (sqrt(sum(err^2)/n)):		6.2733e-05
Maximum absolute error (max(err)):	7.72464e-05
Global absolute error (sum(err^2)):	3.93543e-05

Neumann

Error metrics at t = 1s:
l2 error (sqrt(sum(err^2)/n)):		6.24377e-05
Maximum absolute error (max(err)):	7.4964e-05
Global absolute error (sum(err^2)):	3.89846e-05

@davidscn davidscn mentioned this pull request Jan 24, 2024
Closed
MakisH
MakisH approved these changes Mar 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like something we can easily merge today.

Apart from the value of beta (0.2 instead of 0.3, for consistency with the rest of the tutorials), this is identical to the OpenFOAM-preCICE paper code.

@MakisH
Copy link
Copy Markdown
Member

MakisH commented Mar 11, 2024

I merged develop into this branch. The diff looks a bit different just because of the new formatting config added in #468.

@MakisH MakisH changed the title Add error computation for openfoam solver Add error computation for partitioned-heat-conduction OpenFOAM solver Mar 11, 2024
@MakisH MakisH merged commit ce0f171 into develop Mar 11, 2024
@MakisH MakisH deleted the add-error branch March 11, 2024 07:32
BenjaminRodenberg
BenjaminRodenberg reviewed Mar 13, 2024
View reviewed changes
partitioned-heat-conduction/solver-openfoam/heatTransfer.C
@@ -61,8 +101,8 @@ int main(int argc, char *argv[])

const double alpha = 3;
const double beta = 1.2;
Copy link
Copy Markdown
Contributor

@BenjaminRodenberg BenjaminRodenberg Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MakisH to help with archeology here: In #379 I changed everything to 1.2 according to the FEniCS book.

Copy link
Copy Markdown
Member

@MakisH MakisH Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then the OpenFOAM-preCICE publication is still in synch with the old tutorials, and the new tutorials are in sync with each other. All good, thanks!

@davidscn davidscn mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MakisH MakisH MakisH approved these changes

+1 more reviewer

@BenjaminRodenberg BenjaminRodenberg BenjaminRodenberg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@davidscn davidscn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidscn @MakisH @BenjaminRodenberg