Port elastic-tube-1d solvers to version 3#434
Conversation
|
Closes #395 |
|
I just started a small system test job: https://github.com/precice/tutorials/actions/runs/7492877499/job/20397361340 |
IshaanDesai
left a comment
There was a problem hiding this comment.
I ran several combinations of the C++ and Python participants and everything seems to be working.
|
@valentin-seitz The solid-cpp solver was bugged and produced very bad results before 7de3813.
|
|
@valentin-seitz I checked the uploaded run of the workflow you linked to. For the solid-python fluid-python case, fieldcompare fails, but the exports are close to identical apart from some minor differences. I checked provided meshes only. Is there a way to get more detailed information on what differs? |
|
I ran the version 2 of the elastic-tube-1d with the watchpoint at x=5 on the Fluid Solver and then plotted them using the state of #438 (this PR + #435 + watchpoints and plotting). The result is this: The results of the v2 python solid match the results of this PR. |
|
I'll merge this. We can investigate possible regressions later. |



This PR ports the elastic-tube-1d cpp solvers to version 3
This also rearranges the solvers to follow the pattern read data -> solve -> write data -> advance.
Also fixes the incorrect coordinates in solid-cpp #340