Use mapping:nearest-neighbor in partitioned heat conduction#382
Merged
MakisH merged 1 commit intoprecice:developfrom Oct 14, 2023
Merged
Conversation
IshaanDesai
approved these changes
Oct 9, 2023
MakisH
approved these changes
Oct 14, 2023
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Totally! And I think we may have more such cases where we use RBF while we don't really need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should use nearest neighbor mapping here, because this is sufficient for this simple case with matching meshes. Also consistent with the description in the OpenFOAM adapter paper: