Add ability to compare fields#363
Merged
valentin-seitz merged 11 commits intodevelopfrom Aug 14, 2023
Merged
Conversation
added 9 commits
August 9, 2023 16:58
- Updated test syntax to include reference_results - introduced working generation of reference results
This was
linked to
issues
Aug 13, 2023
MakisH
reviewed
Aug 14, 2023
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Nice! 🚲
Works on my machine (after checking out the precice-config.xml from master).
Some questions for me to better understand, not necessarily something to change. Please ask for review again when ready.
Co-authored-by: Gerasimos Chourdakis <[email protected]>
MakisH
approved these changes
Aug 14, 2023
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Some follow-ups are already in the project board, this can already be merged.
This was referenced Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to compare produced fields. Therefore necessary:
generate_reference_results.pyscript.systemtests.pyThis PR solves:
tests.yamlto contain the reference files #351