Conversation
Added ignore for python objects
We currently have a policy of not having a gitignore in this repository, let's not start one without discussion.
- use openfoam alias - removed the reference output for now
Circular imports are kind of annoying?
|
Is there something I can already try out / review here? |
|
From my side this is stable enough to be merged to develop and iterate there in smaller PRs when adding adapters etc. |
There was a problem hiding this comment.
I have previously reviewed most of the changes in other PRs. This looks good enough for now, let's merge it and start contributing in parallel in smaller PRs.
Of course, it needs some cleanup here and there, but mostly to replace placeholders with their actual implementations.
I could run the tests locally with:
python3 systemtests.py --suites=openfoam-adapter-releasewhich fails because of mismatch between tutorials branch (based on develop) and preCICE version (v2.5.0). Checking out the case files from master helped:
git checkout master -- ../../flow-over-heated-plateBefore running again, one needs to remove the temporary runs/ folder in the tutorials root. These files are currently owned by root (@valentin-seitz please open an issue).
I was also able to trigger the workflow from the GitHub CLI (which succeeded).
| @@ -0,0 +1,13 @@ | |||
| image: "ghcr.io/precice/openfoam-adapter:{{ params["openfoam-adapter-ref"] }}" # TODO: Update | |||
There was a problem hiding this comment.
Remember to overwrite this file later
2 participants
This PR introduces a first systemtests which is working good enough to be mergeable into develop.
Currently the following things work:
gh workflow run run_testsuite.yml --ref add-systemtestsafterwards it would begh workflow run run_testsuite.yml --ref developWhat still needs to be done:
tests.yamlto contain the reference files #351)