Update all FEniCS participants to be compatible with precice:develop (v3)#333
Update all FEniCS participants to be compatible with precice:develop (v3)#333BenjaminRodenberg merged 18 commits intodevelopfrom
Conversation
…and fenics-adapter updates
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
I ran the cases that work exclusively with FEniCS and fixed a few mistakes here. This seems to work. Did not have the time to also check the cases like elastic-tube-3d, flow-over-heated-plate and perpendicular-flap. Looking at the changes in the diff it looks reasonable, but I think we should definitely run them as well before merging.
* Synchronize with 748c934 from precice/fenics-adapter#153
|
I updated the basic version of the partitioned heat conduction w.r.t precice/fenics-adapter#153. The other tutorials are still missing, but generally the case seems to work again. |
|
@IshaanDesai Anything holding us back from merging this PR as soon as its "sibling" precice/fenics-adapter#153 is ready? |
No, nothing holding us back. Running the tutorials manually with the corresponding adapter PR branch should be a sufficient check to merge this. |
|
I'll do a final round of testing and then I will merge. If other adapters still need an update and there is no possibility for testing, I will rely on just checking the diff for sanity. The basis for the tests are the following components:
|
2 participants
This PR updates all FEniCS participants to be compatible with precice:develop. The changes should be tested with precice/fenics-adapter#153. Manual testing is necessary, and once cases are known to work, this PR needs to be merged so that the PR mentioned earlier can be tested via CI.