oscillator: update to v3 API#332
Merged
BenjaminRodenberg merged 1 commit intoprecice:developfrom Apr 3, 2023
Merged
Conversation
Contributor
Author
|
Not sure whether we already want to break and update the tutorials, but I guess having a PR for this case already makes sense, because I had these changes locally anyway. |
IshaanDesai
approved these changes
Mar 28, 2023
Member
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
I ran this tutorial with the latest precice:develop and everything seems to be in order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the oscillator case to the latest state of the preCICE v3 API (precice/python-bindings@166c6e1 etc.)