Conversation
2 tasks
MakisH
reviewed
May 19, 2023
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
This PR is already in a very good shape. Thanks for making it so clean and easy to review!
I think the only potentially interesting part is moving the flow-over-heated-plate-partitioned-flow from a composition of explicit+implicit to a multi-implicit scheme (is possible and wanted). Everything else should be very easy & quick to adjust.
flow-over-heated-plate-partitioned-flow/fluid1-openfoam/system/decomposeParDict
Show resolved
Hide resolved
...plate-partitioned-flow/fluid2-openfoam/0/uniform/functionObjects/functionObjectProperties.gz
Show resolved
Hide resolved
flow-over-heated-plate-partitioned-flow/fluid2-openfoam/system/blockMeshDict
Outdated
Show resolved
Hide resolved
Member
|
Also here, regarding the linting issue (bare URL), just rebase on develop. |
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Member
|
We currently have the following situation:
@thesamriel Please add note alerts at the top of every tutorial, explaining the dependencies. I don't think we can have a new adapter release today, so refer to preCICE v2 and your adapter branch for now. |
MakisH
approved these changes
Jun 13, 2023
MakisH
added a commit
to precice/precice.github.io
that referenced
this pull request
Jun 14, 2023
Makes the tutorials introduced in precice/tutorials#326 discoverable
uekerman
pushed a commit
to precice/precice.github.io
that referenced
this pull request
Jun 14, 2023
Makes the tutorials introduced in precice/tutorials#326 discoverable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates and adds tutorials on fluid-fluid coupling with the OpenFOAM adapter.
Partitioned Pipe:
Partitioned Flow over Backwards Facing Step:
Flow over Heated Plate with Flow Partitioning:
Tutorials were tested with: