Skip to content

Channel transport with OpenFOAM#315

Merged
MakisH merged 21 commits intodevelopfrom
channel_transport_OF
Aug 15, 2023
Merged

Channel transport with OpenFOAM#315
MakisH merged 21 commits intodevelopfrom
channel_transport_OF

Conversation

@tirgendetwas
Copy link
Copy Markdown
Contributor

@tirgendetwas tirgendetwas commented Dec 5, 2022 •
edited
Loading

Channel transport tutorial using OpenFOAM for the fluid participant (and Nutils for the transport participant).

Tested with serial-explicit and parallel-explicit coupling, with sequential and parallel (MPI) runs for the OpenFOAM solver.

  • updated README.md

@uekerman
Copy link
Copy Markdown
Member

uekerman commented Jan 10, 2023

Good to have this new case!
Is there a motivation for adding it as a separate case and not "simply" extending https://precice.org/tutorials-channel-transport.html that I don't see?

@MakisH
Copy link
Copy Markdown
Member

MakisH commented Jan 10, 2023

Good to have this new case! Is there a motivation for adding it as a separate case and not "simply" extending https://precice.org/tutorials-channel-transport.html that I don't see?

There is no particular motivation. This is still a draft and @tirgendetwas is planning to move the case there.

@tirgendetwas tirgendetwas requested a review from MakisH January 16, 2023 13:27
MakisH
MakisH approved these changes Jan 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the case and it looks good. The structure is correct and the results look at least qualitatively right (I have not compared to the fluid-nutils).

The only thing missing is an entry in the tutorial's README.md.

@MakisH MakisH mentioned this pull request Mar 30, 2023
Open
MakisH
MakisH reviewed Apr 4, 2023
View reviewed changes
@tirgendetwas tirgendetwas mentioned this pull request May 5, 2023
Merged
2 tasks
@MakisH
Copy link
Copy Markdown
Member

MakisH commented May 5, 2023

@tirgendetwas this looks ready, maybe mark it as "ready for review"?

Please resolve some conflicts on the channel-transport/precice-config.xml. The linting issues are not related to your changes.

@tirgendetwas tirgendetwas marked this pull request as ready for review May 5, 2023 15:17
@tirgendetwas tirgendetwas marked this pull request as draft May 5, 2023 15:27
MakisH
MakisH reviewed Jul 18, 2023
View reviewed changes
@tirgendetwas tirgendetwas marked this pull request as ready for review August 10, 2023 23:07
MakisH
MakisH requested changes Aug 11, 2023
View reviewed changes
@MakisH MakisH merged commit 1a1f2d5 into develop Aug 15, 2023
@MakisH MakisH deleted the channel_transport_OF branch August 15, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uekerman uekerman uekerman left review comments

@MakisH MakisH MakisH approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tirgendetwas @uekerman @MakisH