Conversation
uekerman
left a comment
There was a problem hiding this comment.
The suggested change makes things clearer, yes, but I don't particularly like to use other participants names.
An alternative could be to use geometric names: Fluid-Upstream-Mesh-Centers and Fluid-Downstream-Mesh-Centers. Then, probably Solid1 should also become Solid-Upstream etc.
We have no conventions yet for such multi-coupling setups.
|
One rule could be In this case, that would be In #301, where the defining participant is CalculiX, we can take the |
|
Yes, sounds good. But then we could also rename |
These names are currently arbitrary and not used anywhere. We just need a name for each list in this dictionary format. |
|
I renamed the participants, meshes, and data fields:
Should I further rename the solid participants to |
|
I documented the conventions in precice/precice.github.io#216. |
Solid1 becomes Solid-Left, and Solid2 becomes Solid-Right following the directory names. We could further rename these, together with the directory names. For the Fluid meshes, we just use Upstream and Downstream as indicators. For the Solid meshes, we follow the usual Participant-Mesh name. The data fields are named based on the Upstream/Downstream.
me too -> |
Fixes #302.
@uekerman how do you like this change? Does it fit our naming scheme?