Skip to content

Fix clean and run for Nutils partitioned-heat#298

Merged
davidscn merged 2 commits intoprecice:developfrom
davidscn:fix-scripts
Oct 17, 2022
Merged

Fix clean and run for Nutils partitioned-heat#298
davidscn merged 2 commits intoprecice:developfrom
davidscn:fix-scripts

Conversation

@davidscn
Copy link
Copy Markdown
Member

Both scripts failed on my OS. Maybe someone else could confirm/approve these changes. A bit confusing that it only pops up now

case ${opt} in
d)
rm -rf Dirichlet-*.vtk
python3 heat.py --side=Dirichlet
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run script runs as expected on my machine without having to do this change.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this, I get Error: invalid argument '--side'

Copy link
Copy Markdown
Member

@IshaanDesai IshaanDesai Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run the case by running ./run.sh -d and ./run.sh -n in two terminals and for me it is still working as expected. Which version of Nutils are you using? I am using Nutils v7.0.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>>> nutils.long_version
'8.0a0'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has now already been incorporated via #295

Copy link
Copy Markdown
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in the clean script is indeed necessary, it does not work currently for me. The run script change does not appear to be necessary on my machine, the current script works just fine.

@davidscn davidscn merged commit ccd0cbd into precice:develop Oct 17, 2022
@davidscn davidscn deleted the fix-scripts branch October 17, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants