Add tutorial: partitioned oscillator#297
Merged
BenjaminRodenberg merged 24 commits intoprecice:developfrom Nov 4, 2022
Merged
Conversation
* Tutorial illustrates a simple case which can be used for convergence studies and waveforms * Case is taken from V. Schüller, B. Rodenberg, B. Uekermann and H. Bungartz, A Simple Test Case for Convergence Order in Time and Energy Conservation of Black-Box Coupling Schemes, in: WCCM-APCOM2022. URL https://www.scipedia.com/public/Rodenberg_2022a
Contributor
Author
|
@valentinaschueller: Feel free to take a look and give comments, if you want 😁 |
uekerman
reviewed
Sep 30, 2022
BenjaminRodenberg
changed the title
Contributor
Author
|
uekerman
reviewed
Oct 31, 2022
Member
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
Nice job, thanks for adding this. A few minor tweaks below.
Important problem. With preCICE v2, I run into:
(0) 14:51:57 [impl::SolverInterfaceImpl]:587 in isActionRequired: ERROR: initialize() has to be called before isActionRequired(...).
Seems that this tutorials only works with develop-v3.0.0.
I did not yet check all details.
uekerman
approved these changes
Nov 2, 2022
Member
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
Runs for me. A small final doubt below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.