Skip to content

added solid solver based on the python bindings for Dune-Fem#274

Merged
uekerman merged 6 commits intoprecice:developfrom
NiklasKotarsky:master
Jun 10, 2022
Merged

added solid solver based on the python bindings for Dune-Fem#274
uekerman merged 6 commits intoprecice:developfrom
NiklasKotarsky:master

Conversation

@NiklasKotarsky
Copy link
Copy Markdown
Contributor

@NiklasKotarsky NiklasKotarsky commented Apr 28, 2022

@uekerman
Copy link
Copy Markdown
Member

Thanks, @NiklasKotarsky 👍

Is this a duplication of #270 or an extension?
If you want to continue here, we should close the other one then.

@NiklasKotarsky
Copy link
Copy Markdown
Contributor Author

Ok, I have extended #270 to also include implicit coupling.

@MakisH
Copy link
Copy Markdown
Member

MakisH commented May 25, 2022

Thanks a lot for contributing! Not sure what the state of it is, but when you are ready for a review, please also include some documentation in the README.md of the parent folder. Please also extend the PR description with a few more details.

@NiklasKotarsky NiklasKotarsky changed the title dune-fem python solver added for the tutorial flow over heated plate added solid solver based on the python bindings for Dune-Fem May 31, 2022
Copy link
Copy Markdown
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for adding this 👍

@uekerman
Copy link
Copy Markdown
Member

uekerman commented Jun 9, 2022

Also added the "adapter" to the website: precice/precice.github.io#173

Copy link
Copy Markdown
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the tutorial and it seems to work 👍 Only problem for me was that I really needed to use a virtual environment, something our users may not be familiar with as well.

Note that one needs to make pyprecice and scipy available as well, e.g., with installing them again in the environment. By default, we ask users to install with pip3 install --user.

Thanks a lot for the contribution, this tutorial is shaping up really nicely! 😄

Co-authored-by: Gerasimos Chourdakis <[email protected]>
@uekerman uekerman merged commit e5fffa6 into precice:develop Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants