Conversation
davidscn
approved these changes
Feb 7, 2022
Member
Author
|
I have ran a few of the cases locally and I had another look at the diff. Merging now, so that any issues will be raised as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does a minor cleanup over all OpenFOAM cases. It is definitely a "high effort / low benefit" task, but these tiny aspects always looked strange and sometimes also triggered confusion.
Summary:
FoamFileonly needsversion,format,class, andobject(mandatory but not used). Thelocationis optional and it was, in many cases, misleading. Anything else is probably a relic from the original tool/source.RASoptions fromturbulentProperties(since we always setlaminar).fvSchemesin the heat-exchanger (probably relic from SimScale).radiationPropertiesfrom the heat-exchanger.We can probably still cleanup a lot if we look at the semantics and default settings, but we can also do this in a later point. If anyone has any suggestions for usual suspects to check and cleanup, they are very welcome!
I have collected all the changes for each case in one commit, for easier review.
@davidscn a second pair of eyes would be useful here.