Skip to content

Cleanup OpenFOAM configuration files#258

Merged
MakisH merged 11 commits intodevelopfrom
cleanup-openfoam
Feb 7, 2022
Merged

Cleanup OpenFOAM configuration files#258
MakisH merged 11 commits intodevelopfrom
cleanup-openfoam

Conversation

@MakisH
Copy link
Copy Markdown
Member

@MakisH MakisH commented Feb 6, 2022

This does a minor cleanup over all OpenFOAM cases. It is definitely a "high effort / low benefit" task, but these tiny aspects always looked strange and sometimes also triggered confusion.

Summary:

  • Remove optional or completely foreign fields from the headers. A FoamFile only needsversion, format, class, and object (mandatory but not used). The location is optional and it was, in many cases, misleading. Anything else is probably a relic from the original tool/source.
  • Bring a bit of consistency in the indentation.
  • Remove misleading and version-specific OpenFOAM copyright notices. These are not OpenFOAM files and it is quite a stretch to keep the headers here.
  • Remove the RAS options from turbulentProperties (since we always set laminar).
  • Remove some duplicate settings (setting the same value as the default) from fvSchemes in the heat-exchanger (probably relic from SimScale).
  • Remove the unused radiationProperties from the heat-exchanger.
  • Update the note regarding pimpleDyMFoam to make it really a special case that most people should not worry about.
  • Some whitespace and formatting here and there.

We can probably still cleanup a lot if we look at the semantics and default settings, but we can also do this in a later point. If anyone has any suggestions for usual suspects to check and cleanup, they are very welcome!

I have collected all the changes for each case in one commit, for easier review.

@davidscn a second pair of eyes would be useful here.

@MakisH MakisH requested a review from davidscn February 6, 2022 23:25
@MakisH MakisH self-assigned this Feb 6, 2022
Copy link
Copy Markdown
Member

@davidscn davidscn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied changes look good. I did not go through all OpenFOAM files we have in this repo additionally.

@MakisH
Copy link
Copy Markdown
Member Author

MakisH commented Feb 7, 2022

I have ran a few of the cases locally and I had another look at the diff. Merging now, so that any issues will be raised as soon as possible.

@MakisH MakisH merged commit 4c58bce into develop Feb 7, 2022
@MakisH MakisH deleted the cleanup-openfoam branch February 7, 2022 07:55
@MakisH MakisH added this to the v202104.2.0 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants