Reduce the writing frquency of partitioned-pipe#257
Merged
Conversation
davidscn
approved these changes
Feb 4, 2022
Member
davidscn
left a comment
davidscn
left a comment
There was a problem hiding this comment.
Might be relevant when working on precice/openfoam-adapter#93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running the partitioned-pipe in an OpenFOAM Adapter custom build, I noticed that the results were approx. 160MB in size, which is, I think, unreasonable for what we need.
This increases the
writeTimefrom0.01to0.1. This is 10x fewer files, while 0.1s is still enough to capture the initial discontinuity (this may turn interesting later on in results comparisons).I did not switch on results compression (i.e., making the output files binary), since eventually we may want to store them as reference results here and make some easy-to-check file comparisons, at least for the last time. If in the end we only check preCICE VTK files, we can enable compression everywhere.
@davidscn does this sound reasonable? Should we absolutely apply the same change to some other tutorial? If not, feel free to merge.