flow-over-heated-plate: Remove unnecessary parameter#234
Conversation
|
I also removed |
BenjaminRodenberg
changed the title
|
Have you also tried this with different OpenFOAM versions? I can imagine that this was there for technical reasons, even if not used. But most probably this originates from the very first prototypes, which were probably also based on something else (as is common in OpenFOAM). |
Of course, not 😏 |
|
@BenjaminRodenberg Don't forget the changelog entry. |
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Indeed. From the OpenFOAM 8 docs:
nMoles: number of moles of component. This entry is only used for combustion modelling based on regress variable with a homogeneous mixture of reactants; otherwise it is set to 1.
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
This looks correct. From the OpenFOAM.org user guide:
nMoles: number of moles of component. This entry is only used for combustion modelling based on regress variable with a homogeneous mixture of reactants; otherwise it is set to 1.
3 participants
See #226 (comment): From my current perspective, we do not need
nMoles.